More clippyification #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another inline format arg. Signed-off-by: Jeremy Kerr <[email protected]>
mkj
reviewed
Jul 24, 2025
mctp-estack/src/lib.rs
Outdated
| #![allow(clippy::int_plus_one)] | ||
| #![allow(clippy::too_many_arguments)] | ||
|
|
||
| // clippy may interpret defmt's log macros as those of the log crate, but |
Member
There was a problem hiding this comment.
The comment isn't quite right - it does recognise when it's log::warn vs defmt::warn. But we can't act on the advice when it tells us to change log:: ones.
Member
Author
There was a problem hiding this comment.
ah, gotchya. will update, and see if we can safely clippy in both log and defmt cases.
The format macros may be defmt, which does not allow inline. Signed-off-by: Jeremy Kerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional clippy fixups for things that miss CI